Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expm1 op and test #33066

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Add expm1 op and test #33066

merged 1 commit into from
Jun 11, 2021

Conversation

ronny1996
Copy link
Contributor

@ronny1996 ronny1996 commented May 24, 2021 •
edited
Loading

PR types

New features

PR changes

OPs

Describe

Add expm1 op and test

image
image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

qili93
qili93 reviewed May 25, 2021
View reviewed changes
python/paddle/fluid/tests/unittests/test_activation_op.py Outdated
@@ -73,6 +73,80 @@ def init_kernel_type(self):
pass


class TestExpm1(OpTest):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里可以参考class TestSigmoid(TestActivation) 直接继承TestActivation里面的func，把有区别的部分重写，其余不需要重写。

qili93
qili93 reviewed May 25, 2021
View reviewed changes
python/paddle/tensor/math.py
@@ -45,6 +45,7 @@
from ..fluid.layers import cosh # noqa: F401
from ..fluid.layers import exp # noqa: F401
from ..fluid.layers import exp_ # noqa: F401
from ..fluid.layers import expm1 # noqa: F401
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tensor/init.py 文件也需要修改

@qili93
Copy link
Contributor

qili93 commented May 25, 2021

同时需要添加对应的docs的中文文档，参考这个 http://agroup.baidu.com/paddlepaddle/md/article/3821189，以及这个PR PaddlePaddle/docs#3526 生成相应的文档预览。

@ronny1996 ronny1996 mentioned this pull request May 26, 2021
Merged
@ronny1996 ronny1996 requested a review from qili93 May 28, 2021 03:03
@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 4, 2021

Sorry to inform you that de0a6e9's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

qili93
qili93 approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TCChenlong
TCChenlong approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TCChenlong
TCChenlong approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 merged commit 5cca9e4 into PaddlePaddle:develop Jun 11, 2021
@ronny1996 ronny1996 deleted the expm1_op branch June 17, 2021 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCChenlong TCChenlong TCChenlong approved these changes

@qili93 qili93 qili93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronny1996 @qili93 @TCChenlong